[readState] tolerant short delay when read from contract staking indexer #4458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envestcc
requested review from
CoderZhi,
dustinxie and
Liuhaai
as code owners
dustinxie
reviewed
Oct 29, 2024
dustinxie
reviewed
Oct 29, 2024
dustinxie
reviewed
Oct 30, 2024
dustinxie
approved these changes
Oct 30, 2024
dustinxie
reviewed
Nov 19, 2024
| if indexWithStart.StartHeight() >= height { | ||
| return false, nil | ||
| } | ||
| } |
There was a problem hiding this comment.
add a startHeight in delayTolerantIndexer struct, and move this type assertion (and save its start height) when creating the instance one-time, so can directly use the value here:
if c.startHeight >= height {
return false, nil
}
CoderZhi
approved these changes
Nov 21, 2024
|
dustinxie
pushed a commit
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the height of the indexer may briefly lag behind BlockDAO by 1, which can result in errors when querying the indexer.
To avoid this issue, we should increase a short waiting time when querying data from the indexer if we find that the height is behind.
In the specific implementation, we have introduced
delayTolerantIndexerto implement this feature by wrapping the underlying indexer.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: